Update running-idom.rst #710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The run function does not have a `config` kwarg but instead `server_config`
rmorshea
approved these changes
Mar 17, 2022
|
Thanks @jmtaysom for the contribution! A note on |
|
I saw some of the chatter in the issues about that. I am definitely all for
that. I have also had issues with the shared runtime in the tutorial. So
that may be a section to clean up in the future if it doesn't get cleaned
up automatically by moving away from the run command.
…On Wed, Mar 16, 2022, 8:36 PM Ryan Morshead ***@***.***> wrote:
Thanks @jmtaysom <https://github.com/jmtaysom>, a note on this, we're
thinking about making some changes
<#657> to the run function since
it encourages some bad habits - namely that you should use a production
WSGI <https://wsgi.readthedocs.io/en/latest/servers.html> or ASGI
<https://asgi.readthedocs.io/en/latest/implementations.html> web server
instead of the run function. In the future idom.run will become a tool
for convenience while developing rather than something that should be used
in production.
—
Reply to this email directly, view it on GitHub
<#710 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB337P47JSTFAGIZYVI37Q3VAJ47PANCNFSM5Q5NKOMQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Can you link to particular sections of the docs that you found to be problematic? I'll create an issue to track that. |
|
https://idom-docs.herokuapp.com/docs/guides/getting-started/running-idom.html?highlight=server%20name#available-server-types
When I ran the above section about SharedClientStateServer I get the
following error
sanic.exceptions.SanicException: Sanic instance named
'idom.server.sanic[1]' uses an invalid format. Names must begin with a
character and may only contain alphanumeric characters, _, or -.
.I ran the same section with an explicitly created and named sanic app and
passed that app into the run function which let it work but I still
couldnt get two windows to update each other as I moved the slider
…On Wed, Mar 16, 2022 at 8:40 PM Ryan Morshead ***@***.***> wrote:
I have also had issues with the shared runtime in the tutorial
Can you link to particular sections of the docs that you found to be
problematic? I'll create an issue to track that.
—
Reply to this email directly, view it on GitHub
<#710 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB337PZFD2YDVO3AV5H4WWDVAJ5QZANCNFSM5Q5NKOMQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
It looks like there may be two separate problems here. I'll open a discussion so we can tease them out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The run function does not have a
configkwarg but insteadserver_config